Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Helm Chart to apache-airflow docs #16014

Merged
merged 3 commits into from
May 23, 2021
Merged

Conversation

mik-laj
Copy link
Member

@mik-laj mik-laj commented May 23, 2021

Based on: #12755

Close: #10523


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@mik-laj mik-laj requested a review from kaxil as a code owner May 23, 2021 16:51
@mik-laj mik-laj requested review from potiuk and ryw May 23, 2021 16:51
Copy link
Member

@kaxil kaxil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions

@github-actions
Copy link

The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest master or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label May 23, 2021
Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also mention the image which is the foundation for the Helm Chart.

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
@mik-laj
Copy link
Member Author

mik-laj commented May 23, 2021

@potiuk Added.

@mik-laj mik-laj merged commit 74821c8 into apache:master May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:documentation okay to merge It's ok to merge this PR as it does not require more tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Host Airflow-managed Helm repo
3 participants