-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify return value check in python virtualenv jinja template #16049
Modify return value check in python virtualenv jinja template #16049
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
|
Wouldn’t the test still pass even if you don’t fix the issue? I think you need to actually test the return value is |
@uranusjr Good point - have added checks on the values returned by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one!
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
Thanks @potiuk - it seems that the
Looks like unrelated to my change - worth rerunning maybe? |
Plese rebase to latest master. The pyarrow limitation is removed there @enisnazif in #16026 |
e5da9a4
to
6be1dc6
Compare
Just running the tests :) |
Awesome work, congrats on your first merged pull request! |
This PR fixes #16022 by changing the check on the return value of a python callable run by the
PythonVirtualEnvOperator