Don't fail to log if we can't redact something #16118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @madison-ookla |
potiuk
approved these changes
May 27, 2021
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
|
Awesome, thanks @ashb! |
kaxil
approved these changes
May 27, 2021
ashb
force-pushed
the
log-masking-non-str-args
branch
from
9763858
to
ed7cc4e
Compare
Rather than dying with an exception, catch it and warn about that, asking users to report it to us. Additionally handle the specific case where a file handle/IO object is logged -- we definitely don't want to iterate over that!
ashb
force-pushed
the
log-masking-non-str-args
branch
from
ed7cc4e
to
3bf83df
Compare
jhtimmins
pushed a commit
that referenced
this pull request
Jun 10, 2021
Rather than dying with an exception, catch it and warn about that, asking users to report it to us. Additionally handle the specific case where a file handle/IO object is logged -- we definitely don't want to iterate over that! (cherry picked from commit 57bd6fb)
ashb
added a commit
that referenced
this pull request
Jun 22, 2021
Rather than dying with an exception, catch it and warn about that, asking users to report it to us. Additionally handle the specific case where a file handle/IO object is logged -- we definitely don't want to iterate over that! (cherry picked from commit 57bd6fb)
kaxil
pushed a commit
to astronomer/airflow
that referenced
this pull request
Jun 23, 2021
Rather than dying with an exception, catch it and warn about that, asking users to report it to us. Additionally handle the specific case where a file handle/IO object is logged -- we definitely don't want to iterate over that! (cherry picked from commit 57bd6fb) (cherry picked from commit 7603ef6) (cherry picked from commit 41ae709)
kaxil
pushed a commit
to astronomer/airflow
that referenced
this pull request
Jun 23, 2021
Rather than dying with an exception, catch it and warn about that, asking users to report it to us. Additionally handle the specific case where a file handle/IO object is logged -- we definitely don't want to iterate over that! (cherry picked from commit 57bd6fb) (cherry picked from commit 7603ef6) (cherry picked from commit 41ae709) (cherry picked from commit ae0d119)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than dying with an exception, catch it and warn about that, asking users to report it to us.
Closes #16071 in the general case, and in the specific write-only IO object that caused the exception.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.