-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a calendar field to choose the execution date of the DAG when triggering it #16141
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea! But it looks like test_views_trigger_dag.py
is failing
@bbovenzi I fixed the failing test but the CI still fails for mssql but it doesn't really say where and I can't even seem to run it on breeze. |
Thanks @mrbaguvix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Past and future dates work great.
@ashb or @ryanahamilton Can we restart the CI here? |
Restarted. |
This PR needs rebasing on to get the master->main rename |
87e3499
to
b0661c7
Compare
@JPonte could you resolve the conflicts and hopefully we can get this merged soon. |
b0661c7
to
9c13a58
Compare
@bbovenzi I fixed the conflicts with main but the checks still timeout on the "Wait for CI images" job. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you expand the tests to see what the behaviour is when an invalid date is submitted please?
Something like: it should still be a 200, but there should be a error message somewhere.
9c13a58
to
0443c89
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
Currently the Trigger DAG always triggers a DAG run with
now()
as execution date. Sinceexecution_date
is a parameter of the dagrun the same wayconf
is, it makes sense to be able to change it in the UI as well.