Correctly handle None returns from Query.scalar() #16345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
requested review from
ashb,
kaxil,
ryanahamilton,
turbaszek and
XD-DENG
as code owners
boring-cyborg
bot
added
area:Scheduler
kaxil
approved these changes
Jun 9, 2021
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
ashb
reviewed
Jun 10, 2021
uranusjr
force-pushed
the
scalar-none-fixes
branch
from
a70df2a
to
7a36545
Compare
This is possible when the query does not return a row, according to SQLAlchemy documentation. We can handle them to provide better errors in unexpected situations.
uranusjr
force-pushed
the
scalar-none-fixes
branch
from
7a36545
to
2518f90
Compare
ashb
pushed a commit
that referenced
this pull request
Jun 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toward #8171, fix #16328.
Noneis possible when the query does not return a row, according to SQLAlchemy documentation. We can handle them to provide better errors in unexpected situations.