Fix external elasticsearch logs link #16357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the 2.0 upgrade, the external log link when using elasticsearch remote logs was broken. This fixes it, including it only being shown if `[elasticsearch] frontend` is set.
kaxil
approved these changes
Jun 15, 2021
|
Thank you for fixing this @jedcunningham! |
73 tasks
jhtimmins
pushed a commit
that referenced
this pull request
Aug 12, 2021
During the 2.0 upgrade, the external log link when using elasticsearch remote logs was broken. This fixes it, including it only being shown if `[elasticsearch] frontend` is set. (cherry picked from commit e31e515)
kaxil
pushed a commit
that referenced
this pull request
Aug 13, 2021
During the 2.0 upgrade, the external log link when using elasticsearch remote logs was broken. This fixes it, including it only being shown if `[elasticsearch] frontend` is set. (cherry picked from commit e31e515)
kaxil
pushed a commit
that referenced
this pull request
Aug 13, 2021
During the 2.0 upgrade, the external log link when using elasticsearch remote logs was broken. This fixes it, including it only being shown if `[elasticsearch] frontend` is set. (cherry picked from commit e31e515)
kaxil
pushed a commit
that referenced
this pull request
Aug 14, 2021
During the 2.0 upgrade, the external log link when using elasticsearch remote logs was broken. This fixes it, including it only being shown if `[elasticsearch] frontend` is set. (cherry picked from commit e31e515)
kaxil
pushed a commit
that referenced
this pull request
Aug 17, 2021
During the 2.0 upgrade, the external log link when using elasticsearch remote logs was broken. This fixes it, including it only being shown if `[elasticsearch] frontend` is set. (cherry picked from commit e31e515)
jhtimmins
pushed a commit
that referenced
this pull request
Aug 17, 2021
During the 2.0 upgrade, the external log link when using elasticsearch remote logs was broken. This fixes it, including it only being shown if `[elasticsearch] frontend` is set. (cherry picked from commit e31e515)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the 2.0 upgrade, the external log link when using elasticsearch
remote logs was broken. This fixes it, including it only being shown if
[elasticsearch] frontendis set.This should be a safe change as nothing is currently using
ExternalLoggingMixin.In 1.10.x, the external links were being toggled by the following, which is why we can't simply add
ExternalLoggingMixininto theElasticsearchTaskHandlerand need the extrasupports_external_linkproperty:airflow/airflow/www_rbac/views.py
Line 1569 in 4aec433
airflow/airflow/www_rbac/views.py
Line 1585 in 4aec433