Remove SQLAlchemy <1.4 constraint #16630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was added due to flask-sqlalchemy and sqlalchemy-utils not declaring the upper bounds. They have since released sqlalchemy 1.4-compatible versions, so we can remove that hack. Note that this does *not* actually make us run on sqlalchemy 1.4 since flask-appbuilder still has a <1.4 pin. But that's for flask-appbuilder to worry about -- code in Airflow is compatible, so we can remove the constraint now, and get sqlalchemy 1.4 as soon as flask-appbuilder allows us to.
uranusjr
force-pushed
the
sqlalchemy-utils-constraints-update
branch
from
b15ce91 to
842ead8
Compare
potiuk
approved these changes
Jun 24, 2021
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
uranusjr
force-pushed
the
sqlalchemy-utils-constraints-update
branch
from
842ead8 to
967aa42
Compare
kaxil
approved these changes
Jun 24, 2021
kaxil
reviewed
Jun 24, 2021
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Jul 12, 2021
FAB 3.3 has some issues with permissions as mentioned in apache#16202 and dpgaspar/Flask-AppBuilder#1667 There is no reason we should require >= 3.3 (This was added in apache#15792) Allow more versions as discussed in apache#16630 (comment)
potiuk
pushed a commit
to potiuk/airflow
that referenced
this pull request
Aug 2, 2021
This was added due to flask-sqlalchemy and sqlalchemy-utils not declaring the upper bounds. They have since released sqlalchemy 1.4-compatible versions, so we can remove that hack. Note that this does *not* actually make us run on sqlalchemy 1.4 since flask-appbuilder still has a <1.4 pin. But that's for flask-appbuilder to worry about -- code in Airflow is compatible, so we can remove the constraint now, and get sqlalchemy 1.4 as soon as flask-appbuilder allows us to. (cherry picked from commit d181604)
potiuk
pushed a commit
to potiuk/airflow
that referenced
this pull request
Aug 5, 2021
This was added due to flask-sqlalchemy and sqlalchemy-utils not declaring the upper bounds. They have since released sqlalchemy 1.4-compatible versions, so we can remove that hack. Note that this does *not* actually make us run on sqlalchemy 1.4 since flask-appbuilder still has a <1.4 pin. But that's for flask-appbuilder to worry about -- code in Airflow is compatible, so we can remove the constraint now, and get sqlalchemy 1.4 as soon as flask-appbuilder allows us to. (cherry picked from commit d181604)
kaxil
pushed a commit
that referenced
this pull request
Aug 17, 2021
This was added due to flask-sqlalchemy and sqlalchemy-utils not declaring the upper bounds. They have since released sqlalchemy 1.4-compatible versions, so we can remove that hack. Note that this does *not* actually make us run on sqlalchemy 1.4 since flask-appbuilder still has a <1.4 pin. But that's for flask-appbuilder to worry about -- code in Airflow is compatible, so we can remove the constraint now, and get sqlalchemy 1.4 as soon as flask-appbuilder allows us to. (cherry picked from commit d181604)
jhtimmins
pushed a commit
that referenced
this pull request
Aug 17, 2021
This was added due to flask-sqlalchemy and sqlalchemy-utils not declaring the upper bounds. They have since released sqlalchemy 1.4-compatible versions, so we can remove that hack. Note that this does *not* actually make us run on sqlalchemy 1.4 since flask-appbuilder still has a <1.4 pin. But that's for flask-appbuilder to worry about -- code in Airflow is compatible, so we can remove the constraint now, and get sqlalchemy 1.4 as soon as flask-appbuilder allows us to. (cherry picked from commit d181604)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was added due to flask-sqlalchemy and sqlalchemy-utils not declaring the upper bounds. They have since released sqlalchemy 1.4-compatible versions, so we can remove that hack.
Note that this does not actually make us run on sqlalchemy 1.4 since flask-appbuilder still has a <1.4 pin. But that's for flask-appbuilder to worry about—code in Airflow is compatible, so we can remove the constraint now, and get sqlalchemy 1.4 as soon as flask-appbuilder allows us to.