Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart: fix labels on cleanup serviceaccount #16722

Merged
merged 1 commit into from
Jun 30, 2021

Conversation

jedcunningham
Copy link
Member

This PR allows both labels and cleanup.enabled to be used at the same time. Previously, the labels were incorrectly indented leading to invalid yaml.

@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label Jun 29, 2021
@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Jun 29, 2021
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@jedcunningham jedcunningham merged commit e3f5eb9 into apache:main Jun 30, 2021
@jedcunningham jedcunningham deleted the cleanup-labels branch June 30, 2021 15:17
@kaxil kaxil added this to the Airflow Helm Chart 1.1.0 milestone Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:helm-chart Airflow Helm Chart okay to merge It's ok to merge this PR as it does not require more tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants