-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add autoscaling subcluster support and remove defaults #17033
Conversation
Build Images / Build PROD images 3.6 (pull_request_target) CI check: |
yep. already fixed. rebase to main will fix it. |
Alright. And what should I do with Mysql test crashes? |
The test failures seem irralevant to your change. (The google and aws providers are broken; we should fix them…) |
@uranusjr r FYI. The problem is that new dependency versions got released during the last few days and they broke our tests. Thanks to our constraint mechanism, this - |
BTW @uranusjr . Before constraints mechanism was in place - such a "third-party-release" was a disastrous event breaking everyone PRs and we needed to scramble to fix those as fast as we could. right now, it will only affect a small subset of PRs (only those that change setup.py/scripts etc.) and we have time to react. This is all by design :). |
Can you please rebase to latest main @peter-volkov ? |
Closed/re-opened to re-trigger build. |
Was on a vacation. Rebased now |
@potiuk is main branch supposed to be green now? |
Sort-of. We had fixed some of the problems but there are som flaky tests still - please rebase and let's see where it gets. We can merge it still if we see only flaky tests failure, this is not a blocker . |
All failures here are out-of-resource of some kind, so probably not related to this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
Indeed. Merging. Do not know about yandex too much, but it looks good. |
@potiuk how do we make a release of |
We release all providers in waves in ~ 1 month cadence. Once this is merged it will be included. The next wave is going to happen in ~ 1.5 - 2 weeks. |
Yandexcloud package dependency is updated.
New autoscaling feature is supported by the operator.
Default values are removed, so they can be set at the server side of the API.
closes: #17031
I have tested the PR using the related example DAG for both airflow 2.0 and 1.10.