Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DAG refresh buttons #17263

Merged
merged 2 commits into from
Jul 29, 2021
Merged

Conversation

jedcunningham
Copy link
Member

Now that the DAG parser syncs DAG specific permissions there really
isn't a need to manually refresh DAGs via the UI.

related: #17166

@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Jul 27, 2021
@jedcunningham jedcunningham added this to the Airflow 2.2 milestone Jul 27, 2021
@bbovenzi
Copy link
Contributor

Sorry, I don't quite understand. Why does permission syncing remove the need for a manual refresh?
I've never been a big fan of the refresh button anyway since it rerenders most of the page.

@ashb
Copy link
Member

ashb commented Jul 28, 2021

The refresh button used to force the webserver to go re-read the dag from the file on disk (and as a result also sync the per-dag permissions.)

But since Airflow 2+ the webserver only looks at the serialized copy and never read the file on disk, so the last remaining thing the refresh button did was update the per-dag permissions defined on the access_control attribute of the DAG.

Copy link
Member

@ashb ashb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The endpoints in the view are not part of either published API, so we can just remove them directly I think.

@bbovenzi
Copy link
Contributor

Makes sense! I didn't see these endpoints being used anywhere else so yeah I agree we can remove them entirely.

Not in this PR, but we may want to reevaluate the action buttons now that there are only two of them.

@jedcunningham
Copy link
Member Author

The endpoints in the view are not part of either published API, so we can just remove them directly I think.

I'm good with that. @kaxil and I were just trying to be extra careful even if it wasn't part of the published API. Seems there is consensus to remove them though 👍

@potiuk
Copy link
Member

potiuk commented Jul 28, 2021

❤️ to remove stuff :)

@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Jul 28, 2021
@jedcunningham jedcunningham changed the title Remove DAG refresh buttons; Deprecate refresh endpoints Remove DAG refresh buttons Jul 28, 2021
Now that the DAG parser syncs DAG specific permissions there really
isn't a need to manually refresh DAGs via the UI.
@jedcunningham jedcunningham merged commit 1394dbe into apache:main Jul 29, 2021
@jedcunningham jedcunningham deleted the remove_refresh branch July 29, 2021 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues okay to merge It's ok to merge this PR as it does not require more tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants