-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Celery 5 #17397
Update to Celery 5 #17397
Conversation
8d7764f
to
640a6f2
Compare
Ah sorry by accident marked it as ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Asumming tests pass…
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
08da660
to
2dff2f7
Compare
Shall I take a look at the deps ? tomorrow I might have some time :) |
@potiuk, have at it. I've not made any progress over the last few days. |
1952fcd
to
bc27610
Compare
Celery 4 is no longer supported as of 2021-08-01: https://docs.celeryproject.org/en/stable/history/whatsnew-5.0.html#long-term-support-policy
Shout out to @uranusjr for identifying the conflicting package! Ready for more eyes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff @jedcunningham @uranusjr -- we needed this since some time now
Oh yeah! Good stuff @uranusjr with the conflict :). This is yet another example where I am waiting for new PIP releases to show the conflicts better :). You need to automate your investigative skills there!. |
Celery 4 is no longer supported as of 2021-08-01:
https://docs.celeryproject.org/en/stable/history/whatsnew-5.0.html#long-term-support-policy
Closes: #11301