Add back missing permissions to UserModelView controls. #17431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashb
approved these changes
Aug 5, 2021
github-actions
bot
added
the
okay to merge
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
|
Should we switch the new tests to use pytest instead? That would make them slightly faster to run. |
andrewgodwin
approved these changes
Aug 5, 2021
|
@uranusjr Given this is blocking a release, I'd suggest it gets landed and then new test refactoring can be done separately. |
kaxil
approved these changes
Aug 9, 2021
|
The failing checks were unrelated and caused by broken main when the PR was created |
jhtimmins
added a commit
that referenced
this pull request
Aug 9, 2021
Currently, on user model views except from UserDBModelView, view controls don't show up on /users/list. This fixes that issue by adding the missing views back to all user model views. Additionally, Edit User on the different Show User views all redirect to the logged in user's profile views. This fixes that issue by removing the Edit User view from Show User. closes: #16202 (cherry picked from commit c1e2af4)
jhtimmins
added a commit
that referenced
this pull request
Aug 13, 2021
Currently, on user model views except from UserDBModelView, view controls don't show up on /users/list. This fixes that issue by adding the missing views back to all user model views. Additionally, Edit User on the different Show User views all redirect to the logged in user's profile views. This fixes that issue by removing the Edit User view from Show User. closes: #16202 (cherry picked from commit c1e2af4)
kaxil
pushed a commit
that referenced
this pull request
Aug 17, 2021
Currently, on user model views except from UserDBModelView, view controls don't show up on /users/list. This fixes that issue by adding the missing views back to all user model views. Additionally, Edit User on the different Show User views all redirect to the logged in user's profile views. This fixes that issue by removing the Edit User view from Show User. closes: #16202 (cherry picked from commit c1e2af4)
jhtimmins
added a commit
that referenced
this pull request
Aug 17, 2021
Currently, on user model views except from UserDBModelView, view controls don't show up on /users/list. This fixes that issue by adding the missing views back to all user model views. Additionally, Edit User on the different Show User views all redirect to the logged in user's profile views. This fixes that issue by removing the Edit User view from Show User. closes: #16202 (cherry picked from commit c1e2af4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, on user model views except from UserDBModelView, view controls don't show up on
/users/list. This fixes that issue by adding the missing views back to all user model views.Additionally,
Edit Useron the differentShow Userviews all redirect to the logged in user's profile views. This fixes that issue by removing theEdit Userview fromShow User.closes: #16202