KEDA task count query should ignore k8s queue #17433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstandish
force-pushed
the
keda-to-ignore-k8s-queue
branch
from
0a246bc
to
3db309b
Compare
CeleryKubernetesExecutor lets us use both celery and kubernetes executors. KEDA lets us scale down to zero when there are no celery tasks running. If we have no celery tasks running, and we run a k8s task, then KEDA will launch a worker even though there are still no celery tasks. We can prevent this from happening by ignoring the kubernetes queue in the KEDA query.
dstandish
force-pushed
the
keda-to-ignore-k8s-queue
branch
from
3db309b
to
ecfa75c
Compare
jedcunningham
requested changes
Aug 5, 2021
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
dstandish
force-pushed
the
keda-to-ignore-k8s-queue
branch
from
69cd7b8
to
957cdad
Compare
jedcunningham
approved these changes
Aug 6, 2021
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
okay to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CeleryKubernetesExecutor lets us use both celery and kubernetes executors.
KEDA lets us scale down to zero when there are no celery tasks running.
The existing KEDA query doesn't look at task
queueso it wil scale up to 1 if there is1 k8s task and 0 celery tasks.
We can prevent this from happening by ignoring the kubernetes queue in the KEDA query.