Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use built-in cached_property on Python 3.8 for Asana provider #17597

Merged
merged 1 commit into from
Aug 13, 2021

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Aug 13, 2021

Functionality is the same, this just removes one dep for Py 3.8+

(same as #14606)


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

Functionality is the same, this just removes one dep for Py 3.8+
@uranusjr
Copy link
Member

Oops, I missed #14606 and it’s already merged. There’s actually a shim for this:

from airflow.compat.functools import cached_property

And it handles type hint better; I added a functools.pyi file to manually provide the annotation.

@kaxil
Copy link
Member Author

kaxil commented Aug 13, 2021

Oops, I missed #14606 and it’s already merged. There’s actually a shim for this:

from airflow.compat.functools import cached_property

And it handles type hint better; I added a functools.pyi file to manually provide the annotation.

I intentionally skipped providers so that users can use this version of provider in older version of Airflow that does not contain from airflow.compat.functools module

@uranusjr
Copy link
Member

Got it!

@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Aug 13, 2021
@kaxil kaxil merged commit d11d3e6 into apache:main Aug 13, 2021
@kaxil kaxil deleted the remove-asana-cached-property branch August 13, 2021 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers full tests needed We need to run full set of tests for this PR to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants