-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong Postgres search_path set up instructions #17600
Conversation
In the set up instructions for Postgres database backend, the instructed command for setting search_path to the correct schema lacks `public` and `utility`, which prevented SqlAlchemy to find all those required schemas.
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
Thanks for the PR! I like changing BTW, can you explain why the |
Regarding the After digging a bit more, here is the output of a preconfigured posgresql from airflow official helm chart:
Only I have also rechecked with a fresh install of airflow using pip, the default search_path works just fine ( As said above, I agree with you the |
You're right. I think the intention of this section is to tell users that if they deploy airflow into a not-default schema, they may need to set the |
Co-authored-by: Xinbin Huang <bin.huangxb@gmail.com>
Postgres config: The step of configuring the search_path is only necessary when Postgres user's search_path has been configured to not include public as all airflow tables lie in public schema. The default search_path is "$user", public, which already contains pubic.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
In the set up instructions for Postgres database backend, the instructed command for setting search_path to the correct schema lacks
public
andutility
, which prevented SqlAlchemy to find all those required schemas.