Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add root to tree refresh url #17633

Merged
merged 1 commit into from
Aug 16, 2021

Conversation

bbovenzi
Copy link
Contributor

We were not passing the root to the /tree_data api call. Therefore, filtering upstream of a task would be reset during auto-refresh even though root was still defined.

Fixes #17533


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

We were not passing the root to the `/tree_data` api call. Therefore, filtering upstream of a task would be reset during auto-refresh even though root was still defined.
@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Aug 16, 2021
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Aug 16, 2021
@ryanahamilton ryanahamilton merged commit c645d7a into apache:main Aug 16, 2021
@ryanahamilton ryanahamilton deleted the add-tree-refresh-root branch August 16, 2021 16:00
@ashb ashb added this to the Airflow 2.2 milestone Aug 17, 2021
@kaxil kaxil modified the milestones: Airflow 2.2, Airflow 2.1.4 Sep 2, 2021
kaxil pushed a commit that referenced this pull request Sep 10, 2021
We were not passing the root to the `/tree_data` api call. Therefore, filtering upstream of a task would be reset during auto-refresh even though root was still defined.

(cherry picked from commit c645d7a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues okay to merge It's ok to merge this PR as it does not require more tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tree-view auto refresh ignores requested root task
4 participants