Separate infer_data_interval for data interval timetables #17755
Conversation
CronDataIntervalTimetable and DeltaDataIntervalTimetable needs different infer_data_interval implementations because since the 'align' method aligns the time *forward*, CronDataIntervalTimetable needs to call get_prev one more time than DeltaDataIntervalTimetable to get the correct interval.
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
| # run at 1am 25th is between 0am 24th and 0am 25th. | ||
| end = self._schedule.get_prev(self._schedule.align(run_after)) | ||
| return DataInterval(start=self._schedule.get_prev(end), end=end) | ||
|
|
||
|
|
||
| class DeltaDataIntervalTimetable(_DataIntervalTimetable): |
There was a problem hiding this comment.
(not related to this PR)
Should we change the name to DataIntervalWithDeltaTimetable ? no strong opinion
There was a problem hiding this comment.
No strong opinion from me either, this name is not intended to be used directly by users anyway (they can just use schedule_interval). The only “complaint” (a weird term considering I named these classes) I have to this (and CronDataIntervalTimetable) is they are so terribly long.
uranusjr
changed the title
CronDataIntervalTimetable and DeltaDataIntervalTimetable needs different infer_data_interval implementations because since the 'align' method aligns the time forward, CronDataIntervalTimetable needs to call get_prev one more time than DeltaDataIntervalTimetable to get the correct interval.