-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix provider.yaml errors due to exit(0) in test #17858
Fix provider.yaml errors due to exit(0) in test #17858
Conversation
I found some errors in provider.yaml while preparing the new issue templates. Turned out that there was a 'sys.exit(0)' in one of the tests (for duplicate integration name) and it "SUCCEEDED" rather than failed, ignoring the rest of the tests. Luckily I caught it before release - but the change is more than one line - I had to move the new local_to_s3 transfer to operators (because it was not a transfer at all). Transfers require two hooks from different providers and this is not the case here. |
How so? There is My suggestion in the issue itself was to do the same as GCP: Same with Azure: |
There were a few errors in provider structure resulting from accidental exit(0) in provider's tests. Luckily none of the changes have been released yet.
f02a34d
to
7f1ad08
Compare
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
There were a few errors in provider structure resulting from
accidental exit(0) in provider's tests. Luckily none of the changes
have been released yet.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.