-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement API endpoint for DAG deletion #17980
Conversation
fea866d
to
3994472
Compare
3994472
to
06401f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just nitpicking :)
I added an |
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
Close #17969.
I’m not sure about the error returned for
DagFileExists
. I was considering 409 Conflict, but Airflow (and Connexion) seems to define that to only represent conflicts on POST. I’m settling for 400 Bad Request, but I feel the current definition is too narrow. The definition in RFC 7231 is much broader and IMO applies here:https://datatracker.ietf.org/doc/html/rfc7231#section-6.5.8