Hide variable import form if user lacks permission #18000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedcunningham
requested review from
ashb,
bbovenzi and
ryanahamilton
as code owners
boring-cyborg
bot
added
area:UI
jedcunningham
changed the title
This hides the variable import form if the user does not have the "can create on variable" permission.
jedcunningham
force-pushed
the
hide_varimport_form
branch
from
4c5cea8 to
1275a6f
Compare
uranusjr
approved these changes
Sep 3, 2021
github-actions
bot
added
the
okay to merge
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
xinbinhuang
approved these changes
Sep 3, 2021
ephraimbuddy
approved these changes
Sep 3, 2021
kaxil
pushed a commit
that referenced
this pull request
Sep 10, 2021
This hides the variable import form if the user does not have the "can create on variable" permission. (cherry picked from commit 7b3a5f9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hides the variable import form if the user does not have the "can
create on variable" permission.
Before or if the user has "can create on variable":
After for users without "can create on variable":
