Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix constraints generation scripts #18094

Merged
merged 1 commit into from
Sep 9, 2021

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Sep 8, 2021

We are now generating constraints with better description, and
we include information about DEFAULT_BRANCH (main/v2-1-test etc.)

The scripts to generate the constraints need to get teh variable
passed to docker.

Also names of generated files were wrong. The constraints did
not update the right constraint files.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@potiuk potiuk requested a review from ashb as a code owner September 8, 2021 17:37
@potiuk potiuk requested review from kaxil and ephraimbuddy September 8, 2021 17:38
@potiuk potiuk force-pushed the add-default-branch-to-passed-variables branch 3 times, most recently from 8925307 to d585340 Compare September 9, 2021 16:10
@potiuk potiuk changed the title Add 'DEFAULT_BRANCH' to docker variables Fix constraints generation scripts Sep 9, 2021
We are now generatnung constraints with better description, and
we include information about DEFAULT_BRANCH (main/v2-1-test etc.)

The scripts to generate the constraints need to get teh variable
passed to docker.

Also names of generated files were wrong. The constraints did
not update the right constraint files.
@potiuk potiuk force-pushed the add-default-branch-to-passed-variables branch from d585340 to c8a3989 Compare September 9, 2021 16:23
@potiuk
Copy link
Member Author

potiuk commented Sep 9, 2021

Hey @kaxil @ashb @jhtimmins @uranusjr -> this is the change needed to update the constraint generation after I added the descriptions in constraint files. I already generated new constraints in main, but I need to merge this one and cherry-pick it to v2-1-test to rebuild constraints there.

The constraints have now headers explaining what are they needed for, which branch they were generated for and when, so that it is easier to understand what each constrain set is for:

Example main constraints just generated:

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Sep 9, 2021
@github-actions
Copy link

github-actions bot commented Sep 9, 2021

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@potiuk potiuk merged commit afd4ba6 into apache:main Sep 9, 2021
@potiuk potiuk deleted the add-default-branch-to-passed-variables branch September 9, 2021 16:32
potiuk added a commit that referenced this pull request Sep 9, 2021
We are now generatnung constraints with better description, and
we include information about DEFAULT_BRANCH (main/v2-1-test etc.)

The scripts to generate the constraints need to get teh variable
passed to docker.

Also names of generated files were wrong. The constraints did
not update the right constraint files.

(cherry picked from commit afd4ba6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-tools full tests needed We need to run full set of tests for this PR to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants