Fix Sentry handler from LocalTaskJob causing error #18119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashb
approved these changes
Sep 9, 2021
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
kaxil
reviewed
Sep 9, 2021
The `enrich_errors` method assumes the first argument to the function its patch is a TaskInstance when infact it can also be a LocalTaskJob. This is now handled by extracting the task_instance from the LocalTaskJob
robinedwards
force-pushed
the
hotfix/sentry-enrich-errors
branch
from
2471679
to
a07e3f1
Compare
kaxil
approved these changes
Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
enrich_errorsmethod assumes the first argument to the functionits wrapping is a method on a
TaskInstancewhen in fact it can also be aLocalTaskJob. In the case of the mini scheduler :airflow/airflow/jobs/local_task_job.py
Line 224 in 944dcfb
I believe this issue was introduced with #16289
This is now handled by extracting the task_instance from the LocalTaskJob
Closes #18118