Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inherit AirflowNotFound from connextion.NotFound for better readability #18523

Merged
merged 1 commit into from
Sep 26, 2021

Conversation

mattwang44
Copy link
Contributor

These lines in post_set_task_instances_state() tends to

  1. raise NotFound if no dag return based on the given dag_id
  2. catch exception SerializedDagNotFound and raise NotFound

but raising exception in a try-catch clause lowers the readability.

This PR makes AirflowNotFoundException inherited from connextion.NotFound and thus the try-catch can be removed and make post_set_task_instances_state() simpler.

Fixes: #11851

@boring-cyborg boring-cyborg bot added the area:API Airflow's REST/HTTP API label Sep 26, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Sep 26, 2021

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Sep 26, 2021
@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@potiuk potiuk merged commit 7c9aba5 into apache:main Sep 26, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Sep 26, 2021

Awesome work, congrats on your first merged pull request!

@mattwang44 mattwang44 deleted the fix/issue-11851 branch September 26, 2021 08:55
@mattwang44 mattwang44 changed the title inherit AirflowNotFound from connextion.NotFound for better readability Inherit AirflowNotFound from connextion.NotFound for better readability Sep 27, 2021
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Feb 3, 2022
Cherry-pick from community:
apache/airflow#18554 and
apache/airflow#19113 and
apache/airflow#18523

Change-Id: If366bd0ec34d96f736b84c45b18305785dc6e671
GitOrigin-RevId: 3cb294ecbee35e49817880ba95db4467471e5029
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:API Airflow's REST/HTTP API full tests needed We need to run full set of tests for this PR to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inherit AirflowNotFound from connextion.NotFound to make the code simpler
3 participants