-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inherit AirflowNotFound
from connextion.NotFound
for better readability
#18523
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
37eea4b
to
db19f8e
Compare
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
…tter readability
db19f8e
to
223a049
Compare
Awesome work, congrats on your first merged pull request! |
AirflowNotFound
from connextion.NotFound
for better readabilityAirflowNotFound
from connextion.NotFound
for better readability
Cherry-pick from community: apache/airflow#18554 and apache/airflow#19113 and apache/airflow#18523 Change-Id: If366bd0ec34d96f736b84c45b18305785dc6e671 GitOrigin-RevId: 3cb294ecbee35e49817880ba95db4467471e5029
These lines in
post_set_task_instances_state()
tends toNotFound
if no dag return based on the givendag_id
SerializedDagNotFound
and raiseNotFound
but raising exception in a try-catch clause lowers the readability.
This PR makes
AirflowNotFoundException
inherited fromconnextion.NotFound
and thus the try-catch can be removed and makepost_set_task_instances_state()
simpler.Fixes: #11851