-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small improvements for Airflow UI #18715
Conversation
Reopened to rebuild |
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
<h2>Wait a minute.</h2> | ||
<h2>Wait a minute</h2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes in this file are too objective subjective (typo) to me. They may not be wrong (although I don't see how they improve what), but don't fit well with the rest of the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This dot just doesn't look nice in the UI. Short sentences or instructions don't need a dot at the end, especially if they are not included in some bigger text wall, but are just a short notification or instruction. I know it's subjective, but I think it's commonly accepted. Sentences like 'Click OK', 'Check your filters', 'Insert value' do not require a full stop at the end. Also, it is perceived as insincere or even rude nowadays. In my opinion, it looks just better in this case.
I slightly improved some small UI elements that were a bit off.
Changes:
btn-sm
class that made the buttons next to each DAG on DAGs list not centered perfectly.Here I highlighted with red color the old font size and misaligned icons inside button. The green highlights the elements after changes.
![image](https://user-images.githubusercontent.com/7412964/135896512-7b44b5d0-9cda-42d5-a8ea-3151c0dde2a1.png)
If there are any other places that I missed or there is something that shouldn't be changed or maybe the change should be reflected in some places that I missed - let me know!