Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small improvements for Airflow UI #18715

Merged
merged 6 commits into from
Oct 6, 2021
Merged

Conversation

mnojek
Copy link
Contributor

@mnojek mnojek commented Oct 4, 2021

I slightly improved some small UI elements that were a bit off.
Changes:

  • Removed btn-sm class that made the buttons next to each DAG on DAGs list not centered perfectly.
  • Changed everywhere the spelling of DAGs (made the last letter lowercase in 'DAGS' word)
  • Changed the 'Conn Type' and 'Conn Id' to 'Connection Type' Connection Id' (not sure why this whas abbreviated everywhere, but if I am not aware of something, let me know and I can revert this change)
  • Fixed strange use of punctuation marks inside a view when trying to mark DAG run as failed
  • Changed font size inside DAG run circle from 8 to 9. It makes it a lot more readable and it can still fit even 4-digit numbers. I think we can even go with 10, but then 4-digit numbers slightly overlay the circle (who have 4-digit runs though?).

Here I highlighted with red color the old font size and misaligned icons inside button. The green highlights the elements after changes.
image

If there are any other places that I missed or there is something that shouldn't be changed or maybe the change should be reflected in some places that I missed - let me know!

@boring-cyborg boring-cyborg bot added area:core-operators Operators, Sensors and hooks within Core Airflow area:helm-chart Airflow Helm Chart area:logging area:providers area:Scheduler including HA (high availability) scheduler area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues kind:documentation provider:microsoft-azure Azure-related issues provider:google Google (including GCP) related issues labels Oct 4, 2021
@potiuk potiuk closed this Oct 5, 2021
@potiuk potiuk reopened this Oct 5, 2021
@potiuk
Copy link
Member

potiuk commented Oct 5, 2021

Reopened to rebuild

@github-actions
Copy link

github-actions bot commented Oct 5, 2021

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Oct 5, 2021
<h2>Wait a minute.</h2>
<h2>Wait a minute</h2>
Copy link
Member

@uranusjr uranusjr Oct 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in this file are too objective subjective (typo) to me. They may not be wrong (although I don't see how they improve what), but don't fit well with the rest of the PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dot just doesn't look nice in the UI. Short sentences or instructions don't need a dot at the end, especially if they are not included in some bigger text wall, but are just a short notification or instruction. I know it's subjective, but I think it's commonly accepted. Sentences like 'Click OK', 'Check your filters', 'Insert value' do not require a full stop at the end. Also, it is perceived as insincere or even rude nowadays. In my opinion, it looks just better in this case.

@kaxil kaxil merged commit 2a6cadb into apache:main Oct 6, 2021
@mnojek mnojek deleted the ui-improvements branch October 6, 2021 09:27
kaxil added a commit that referenced this pull request Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core-operators Operators, Sensors and hooks within Core Airflow area:helm-chart Airflow Helm Chart area:logging area:providers area:Scheduler including HA (high availability) scheduler area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues full tests needed We need to run full set of tests for this PR to merge kind:documentation provider:google Google (including GCP) related issues provider:microsoft-azure Azure-related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants