-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move docker decorator example dag to docker provider #18739
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should leave the virtualenv task here and separate out the docker task into a separate example DAG in it's provider
2e8e313
to
e17e1be
Compare
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
Hi @potiuk , this failure seems related to DockerDecorator not usable in airflow versions less than 2.2. |
Yep. This is precisely what is expected. The problem is that we try if "ALL" provider code imports nicely for 2.1 without errors - including the examples. In this case we've made a deliberate decision to move the example to "docker" provider, even if it will not work for 2.1. This is fine, so the solution is to try/except the example to get example_dag import without the exception (with appropriate comment). |
This example dag errors out during startup when we set `AIRFLOW__CORE__EXAMPLE_DAGS=True` and docker provider is not installed. separate the examples remove doc text since it's not used in documentation
e17e1be
to
4d708cd
Compare
Done. Please take a look |
This example dag errors out during startup when we set
AIRFLOW__CORE__EXAMPLE_DAGS=True
and dockerprovider is not installed.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.