Always run at least one backfill from BackfillJob #18742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
the
area:Scheduler
Closed
2 tasks
uranusjr
force-pushed
the
aip-39-cli-dag-test-always-run-one
branch
from
385ed4a
to
b111b05
Compare
ashb
approved these changes
Oct 5, 2021
uranusjr
force-pushed
the
aip-39-cli-dag-test-always-run-one
branch
from
b111b05
to
0ba1b42
Compare
kaxil
approved these changes
Oct 5, 2021
uranusjr
force-pushed
the
aip-39-cli-dag-test-always-run-one
branch
from
0ba1b42
to
9ac2dc4
Compare
2 tasks
This restores the behavior around this prior to AIP-39 implementation. It is arguably not correct, but nobody ever complained about it (and they have to the new behavior), so we should meet user expectations.
uranusjr
force-pushed
the
aip-39-cli-dag-test-always-run-one
branch
from
9ac2dc4
to
a197483
Compare
ashb
reviewed
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores the behavior around this prior to AIP-39 implementation. It is arguably not correct, but nobody ever complained about it (and they have to the new behavior), so we should meet user expectations.
Close #18473.