Ensure that dag_id, run_id and execution_date are non-null on DagRun #18804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashb
added
the
full tests needed
uranusjr
approved these changes
Oct 7, 2021
kaxil
requested changes
Oct 7, 2021
|
🤦 |
ashb
force-pushed
the
non-null-dag-runid
branch
from
c845434 to
3d12d07
Compare
kaxil
reviewed
Oct 7, 2021
airflow/migrations/versions/306a0384de71_make_dagrun_id_columns_non_nullable.py
Outdated
Show resolved
Hide resolved
kaxil
approved these changes
Oct 7, 2021
jedcunningham
approved these changes
Oct 7, 2021
|
This didn't apply on mysql, so rather than creating the FK in one migration, then dropping it to alter the column types and then recreating it, we should just change the column types before hand. |
These _should_ be non-nullable, and are always created as such. Without this it was possible that someone had manually edited it which caused problems with the TaskInstance FK migration not applying correctly.
ashb
force-pushed
the
non-null-dag-runid
branch
from
acce77c to
fc1f5be
Compare
|
I am guessing this will be merged into |
|
actually we keep on moving v2-2-test with main but generally speaking this one is marked for 2.2.0 so yeah - it will land in v2-2-test |
|
Only after we cut an RC the branches will diverge |
|
Yup this is now already part of v2-2-test and part of 2.2.0 rc1. https://github.com/apache/airflow/commits/v2-2-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These should be non-nullable, and are always created as such. Without
this it was possible that someone had manually edited it which caused
problems with the TaskInstance FK migration not applying correctly.
Closes #18801
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.