Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra postgres dependency from AWS Provider #18844

Merged
merged 3 commits into from
Oct 10, 2021

Conversation

mariotaddeucci
Copy link
Contributor

@mariotaddeucci mariotaddeucci commented Oct 8, 2021

Removed postgres provider specific versions dependency generated on #18027 (more details on #18671).
Using the RedshiftSQLHook introduced on #18447 and replicating the method get_table_primary_key to it.
The get_table_primary_key wasn't removed from PostgresHook because can be used on it.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg bot added area:providers provider:amazon AWS/Amazon - related issues labels Oct 8, 2021
@mariotaddeucci mariotaddeucci changed the title Remove extra prostgres dependency Remove extra prostgres dependency from AWS Provider Oct 8, 2021
@uranusjr uranusjr closed this Oct 9, 2021
@uranusjr
Copy link
Member

uranusjr commented Oct 9, 2021

Re-triggering CI.

@uranusjr uranusjr reopened this Oct 9, 2021
@potiuk
Copy link
Member

potiuk commented Oct 9, 2021

This one needs also similar change in redshift_to_s3 and example dags @mariotaddeucci . Once you do it, you will see that the dependency betwen S3 and Postgres will be automatically removed (by pre-commit) from https://github.com/apache/airflow/blob/main/airflow/providers/dependencies.json (this is where we take cross-provider dependencies when we generate setup.py for providers).

Only then the [postgres] extra will actually disappear from amazon provider.

@potiuk potiuk changed the title Remove extra prostgres dependency from AWS Provider Remove extra postgres dependency from AWS Provider Oct 9, 2021
@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Oct 10, 2021
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers okay to merge It's ok to merge this PR as it does not require more tests provider:amazon AWS/Amazon - related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants