Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit session parameter in PoolSlotsAvailableDep #18875

Merged

Conversation

avkirilishin
Copy link
Contributor

An open_slots function accepts a session parameter, and it should not commit the transaction itself. The absence of a parameter causes an implicit commit and may lead to undesirable consequences. For example, a task may become orphaned if restarting the scheduler and task creation happens around the same time.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg
Copy link

boring-cyborg bot commented Oct 10, 2021

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Oct 11, 2021
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh. Nice!

An open_slots function accepts a session parameter, and it should not commit the transaction itself. The absence of a parameter causes an implicit commit and may lead to undesirable consequences. For example, a task may become orphaned if restarting the scheduler and task creation happens around the same time.
@avkirilishin avkirilishin force-pushed the pool_slots_available_dep_add_session branch from 2b7a095 to 70b235e Compare October 12, 2021 19:59
@avkirilishin
Copy link
Contributor Author

I reduced the number of queries in the test. Why are two excluded instead of one?
First - implicit COMMIT (expected).
Second - SELECT in new session (SELECT ... FROM task_instance JOIN dag_run ...).

@uranusjr
Copy link
Member

If you're just curious, try changing the expected query count in the test against main and see what assert_queries_count reports 🙂 But less query is always good so that shouldn't affect this PR.

@kaxil kaxil closed this Oct 15, 2021
@kaxil kaxil reopened this Oct 15, 2021
@eladkal eladkal added this to the Airflow 2.2.2 milestone Oct 29, 2021
@uranusjr uranusjr merged commit e0aa36e into apache:main Oct 29, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 29, 2021

Awesome work, congrats on your first merged pull request!

jedcunningham pushed a commit that referenced this pull request Nov 3, 2021
@jedcunningham jedcunningham added the type:bug-fix Changelog: Bug Fixes label Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full tests needed We need to run full set of tests for this PR to merge type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants