-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add explicit session parameter in PoolSlotsAvailableDep #18875
Add explicit session parameter in PoolSlotsAvailableDep #18875
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh. Nice!
An open_slots function accepts a session parameter, and it should not commit the transaction itself. The absence of a parameter causes an implicit commit and may lead to undesirable consequences. For example, a task may become orphaned if restarting the scheduler and task creation happens around the same time.
2b7a095
to
70b235e
Compare
I reduced the number of queries in the test. Why are two excluded instead of one? |
If you're just curious, try changing the expected query count in the test against main and see what |
Awesome work, congrats on your first merged pull request! |
(cherry picked from commit e0aa36e)
An open_slots function accepts a session parameter, and it should not commit the transaction itself. The absence of a parameter causes an implicit commit and may lead to undesirable consequences. For example, a task may become orphaned if restarting the scheduler and task creation happens around the same time.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.