Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade old DAG/task param format when deserializing from the DB #18986

Merged

Conversation

ashb
Copy link
Member

@ashb ashb commented Oct 14, 2021

Reported in #18909 (comment) (doesn't close that issue, there are two points there)

@ashb ashb requested a review from kaxil as a code owner October 14, 2021 14:39
@ashb ashb added this to the Airflow 2.2.1 milestone Oct 14, 2021
@ashb ashb added kind:bug This is a clearly a bug priority:critical Showstopper bug that should be patched immediately labels Oct 14, 2021
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one. Automated upgrade to new Params!

@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Oct 14, 2021
@jedcunningham jedcunningham reopened this Oct 15, 2021
@jedcunningham jedcunningham merged commit 6032159 into apache:main Oct 15, 2021
@jedcunningham jedcunningham deleted the upgrade-params-dict-on-deserialize branch October 15, 2021 16:27
jedcunningham pushed a commit that referenced this pull request Oct 15, 2021
jedcunningham pushed a commit to astronomer/airflow that referenced this pull request Oct 26, 2021
jedcunningham pushed a commit to astronomer/airflow that referenced this pull request Oct 27, 2021
@jedcunningham jedcunningham added the type:bug-fix Changelog: Bug Fixes label Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:serialization full tests needed We need to run full set of tests for this PR to merge kind:bug This is a clearly a bug priority:critical Showstopper bug that should be patched immediately type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants