Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test_connection method for Snowflake Hook #19041

Merged
merged 6 commits into from
Oct 25, 2021

Conversation

msumit
Copy link
Contributor

@msumit msumit commented Oct 18, 2021


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg bot added area:providers provider:snowflake Issues related to Snowflake provider labels Oct 18, 2021
@uranusjr
Copy link
Member

I kind of feel like this is reinventing exceptions. It actually looks a lot like the Result monad in some languages, or Go's if err, result construct. The idiomatic way to do this in Python is exceptions, so

result, err = hook.test_connection()
if result:
    ...  # Success.
else:
    print(f"failed with {err}")

becomes

try:
    hook.check_connection()
except ConnectionFailure as e:
    print(f"failed with {e}")
else:
    ...  # Success.

@msumit
Copy link
Contributor Author

msumit commented Oct 18, 2021

I kind of feel like this is reinventing exceptions. It actually looks a lot like the Result monad in some languages, or Go's if err, result construct. The idiomatic way to do this in Python is exceptions, so

result, err = hook.test_connection()
if result:
    ...  # Success.
else:
    print(f"failed with {err}")

becomes

try:
    hook.check_connection()
except ConnectionFailure as e:
    print(f"failed with {e}")
else:
    ...  # Success.

Make sense.. modified the code..

@msumit msumit changed the title Add test_connection method for Snowflake Add test_connection method for Snowflake Hook Oct 21, 2021
@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Oct 25, 2021
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@uranusjr uranusjr merged commit acfb7b5 into apache:main Oct 25, 2021
@uranusjr uranusjr deleted the snow_test branch October 25, 2021 05:48
sharon2719 pushed a commit to sharon2719/airflow that referenced this pull request Oct 27, 2021
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
@jedcunningham jedcunningham added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) okay to merge It's ok to merge this PR as it does not require more tests provider:snowflake Issues related to Snowflake provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants