Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Labels to jobs created by cleanup pods #19225

Merged
merged 2 commits into from
Oct 26, 2021

Conversation

pgvishnuram
Copy link
Contributor

@pgvishnuram pgvishnuram commented Oct 26, 2021


Problem:
Currently pods created by cleanup jobs doesn't add labels similar to metadata.labels.
This prevents us to use network policies to block / allow to communication to internal services

How does this PR fix the problem above:

This PR adds ability to utilise existing labels and allow to use new labels from values.yaml

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg
Copy link

boring-cyborg bot commented Oct 26, 2021

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

chart/tests/test_cleanup_pods.py Outdated Show resolved Hide resolved
@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Oct 26, 2021
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

forgot to remove  print statement

Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
@kaxil kaxil merged commit d426b46 into apache:main Oct 26, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 26, 2021

Awesome work, congrats on your first merged pull request!

sharon2719 pushed a commit to sharon2719/airflow that referenced this pull request Oct 27, 2021
Problem:
Currently pods created by cleanup jobs doesn't add labels similar to metadata.labels.
This prevents us to use network policies to block / allow to communication to internal services

How does this PR fix the problem above:

This PR adds ability to utilise existing labels and allow to use new labels from values.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:helm-chart Airflow Helm Chart okay to merge It's ok to merge this PR as it does not require more tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants