-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Labels to jobs created by cleanup pods #19225
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
forgot to remove print statement Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
Awesome work, congrats on your first merged pull request! |
Problem: Currently pods created by cleanup jobs doesn't add labels similar to metadata.labels. This prevents us to use network policies to block / allow to communication to internal services How does this PR fix the problem above: This PR adds ability to utilise existing labels and allow to use new labels from values.yaml
Problem:
Currently pods created by cleanup jobs doesn't add labels similar to metadata.labels.
This prevents us to use network policies to block / allow to communication to internal services
How does this PR fix the problem above:
This PR adds ability to utilise existing labels and allow to use new labels from values.yaml
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.