Fix task instance modal in gantt view #19258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2.2.0 removed the execution_date from the task_instance table. So the execution date won't be provided by simply calling `alchemy_to_dict`.
robinedwards
requested review from
ashb,
bbovenzi and
ryanahamilton
as code owners
uranusjr
approved these changes
Oct 27, 2021
github-actions
bot
added
the
okay to merge
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
|
We may need a test for this, but I'm not sure how it should be implemented. |
|
I guess ideally the payload should be served by its own endpoint similar to the way we have |
kaxil
approved these changes
Oct 27, 2021
jedcunningham
pushed a commit
that referenced
this pull request
Nov 5, 2021
(cherry picked from commit aa6c951)
This was referenced Nov 10, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.2.0 removed the execution_date from the task_instance table.
So the execution date won't be provided by simply calling
alchemy_to_dicton the task_instance model. Subsequently this broke the links in the task instance modal on the gantt view.Closes #19252