Switch Markdown engine to markdown-it-py

[torbjornvatn]

As mentioned in #16435 will switching to markdown-it-py give much more advanced Markdown rendering and make it behave almost like to Github Flavored Markdown

closes: #16435
related: #19644

[torbjornvatn]

@ferruzzi This one passed the Static checks

[torbjornvatn]

@ashb I would ideally find a way to remove the display: block; property from a <summary> inside a <display> to get a ‣ in front of the collapsible content just as here on Github. But I couldn't figure out how to change any of the CSS really 🤷🏼

Example:

Click to expand!

Heading

1. A numbered
2. list
   • With some
   • Sub bullets

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

[uranusjr]

Any updates on this?

[torbjornvatn]

Seems like the conflict in airflow/www/utils.py is caused by someone else attempting to do something similar, but with a different Markdown lib than me. Will have to review that change to see if it's merged into master and makes this PR obsolete

[torbjornvatn]

It was something else actually, fixed the conflict now

[uranusjr]

So do we need to do anything special to <summary>’s display: block?

[torbjornvatn]

So do we need to do anything special to <summary>’s display: block?

Are you asking me @uranusjr? I don't really know, do you want me to test it somehow?

[uranusjr]

You said above

I would ideally find a way to remove the display: block; property from a <summary> inside a <display> to get a ‣ in front of the collapsible content just as here on Github.

I was just following that up.

[ashb]

@bbovenzi CSS questions - can you help out please

[torbjornvatn]

You said above

I would ideally find a way to remove the display: block; property from a <summary> inside a <display> to get a ‣ in front of the collapsible content just as here on Github.

I was just following that up.

🤦🏼‍♂️ yes of course. Sorry for not remembering my own questions.

A CSS fix for this would be highly appreciated @bbovenzi The working ‣ for expanding the section is kind of important for the UX

[torbjornvatn]

A friendly reminder on this one @bbovenzi

I can do the CSS changes my self, I just needs some pointers on how

[bbovenzi]

A friendly reminder on this one @bbovenzi

I can do the CSS changes my self, I just needs some pointers on how

My apologies. I kept missing this PR.

We should be able to manipulate the css for markdown simply by adding something like

.rich_doc summary {
  display: block;
}

to main.css

[uranusjr]

The docker-compose quick start is failing because it misses the markdown-it-py package. Maybe there’s some dependency list somewhere we need to fix?

Not sure what’s going on with the Helm Chart tests.

[potiuk]

Docker compose quick-start tests test starting airflow via docker compose and check if the

There is nothing "special" about them they are the usual "integration tests" run by pytest using breeze environment (mainly to get the right dependencies):

It's rather easy to follow what they do:

Started by breeze docker-compose-tests

airflow/.github/workflows/ci.yml

Line 1417 in 749e53d

run: breeze docker-compose-tests

Here are the tests (standard pytest-run python code):

https://github.com/apache/airflow/blob/main/docker_tests/test_docker_compose_quick_start.py

They are also super easy to reproduce and run - you just need to follow what is done in the ci.

There is no magic there. If they do not start, it means that something does not work and you cannot inspect airflow after you use production image to ru docker-compose with airflow.

[potiuk]

Those tests are converted to run standard "breeze" commands and you can always easily locally reproduce it using breeze.

[potiuk]

I just recommend to try to reproduce it following it step-by-step.

[torbjornvatn]

@potiuk and @uranusjr I'm having a really hard time getting all these checks to be ✅ at the same time

The last one was something with the python cache or something, and I'm not allowed to rerun individual workflows either as far as I can see.

[potiuk]

Intermittent problem. I just re-run failed jobs only.

BTW. There is the "re-run failed jobs" button at the top (not sure if you can do it as non-committer though).

[torbjornvatn]

🎉 @potiuk
It worked

[potiuk]

Woooohooo 🎉 🎉 🎉 🎉 🎉 🎉

[potiuk]

Maybe you should provide and test PR with a fix @tronlightracer ? This is the best way to become one of > 2100 contributors to Airflow (mostly people like you).