Databricks: add more methods to represent run state information #19723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexott
force-pushed
the
databricks-issue-19357
branch
2 times, most recently
from
60e0747
to
d607df5
Compare
uranusjr
reviewed
Nov 21, 2021
alexott
force-pushed
the
databricks-issue-19357
branch
from
d607df5
to
052b9f6
Compare
uranusjr
reviewed
Nov 22, 2021
alexott
force-pushed
the
databricks-issue-19357
branch
from
052b9f6
to
30aefea
Compare
uranusjr
reviewed
Nov 23, 2021
uranusjr
reviewed
Nov 23, 2021
uranusjr
reviewed
Nov 23, 2021
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
…nto databricks-issue-19357
uranusjr
reviewed
Nov 23, 2021
Comment on lines
+438
to
+440
| run_state_str = ( | ||
| f"State: {state.life_cycle_state}. Result: {state.result_state}. {state.state_message}" | ||
| ) |
There was a problem hiding this comment.
How about putting this in RunState’s __str__ and just call str(state) here?
There was a problem hiding this comment.
That’s primarily because I’m not sure if it may break something inside airflow. I’m not expert in it (yet)
uranusjr
approved these changes
Nov 23, 2021
github-actions
bot
added
the
okay to merge
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
potiuk
approved these changes
Nov 24, 2021
This was referenced Nov 30, 2021
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a warning about need to use XCOM if
get_run_statefunction is used, plus adds more methods to retrieve information about run statecloses: #19357