-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cancelling of Pull Request builds when image build fails #20939
Fix cancelling of Pull Request builds when image build fails #20939
Conversation
When image build fails, the pull request that triggered it should be cancelled. The apache#15944 introduced rewrite of the GitHub actions code but by mistake it also introduced a failure in cancelling the PR workflow by missing pipeline to jq. In most cases it did not matter, but it cause "wait for images" in PRs to run far longer than they should be. This PR restores cancelling feature.
Hey @ashb - I will test the cancelling after the change but I believe it might explain some "far too long" runnig "wait for image" jobs in case we had breaking "build image" changes in main. |
I propose a change to use |
Thanks @malthe - we are in the process of rewriting all the scripts to python (including those small snippets) as part of #12282 so let's have minimal changes here. I tested tha in https://github.com/potiuk/airflow/runs/4865079794?check_suite_focus=true and piping works as expected:
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
…pache#20939)" This reverts commit b171e03.
When image build fails, the pull request that triggered it should
be cancelled. The #15944 introduced rewrite of the GitHub actions
code but by mistake it also introduced a failure in cancelling
the PR workflow by missing pipeline to jq.
In most cases it did not matter, but it cause "wait for images"
in PRs to run far longer than they should be.
This PR restores cancelling feature.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.