Remove unnecessary loggings from offline sql generation command #21962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ephraimbuddy
requested review from
uranusjr,
jedcunningham,
potiuk,
ashb and
kaxil
uranusjr
reviewed
Mar 3, 2022
ephraimbuddy
force-pushed
the
cleanup-offline-sql
branch
from
26d5159 to
69588c0
Compare
kaxil
reviewed
Mar 3, 2022
kaxil
approved these changes
Mar 3, 2022
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
I found a way to remove unnecessary loggings that comes from validating revisions in the offline migration command. Also cleaned up some codes
Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
ephraimbuddy
force-pushed
the
cleanup-offline-sql
branch
from
c4395ac to
4974af3
Compare
ephraimbuddy
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a way to remove unnecessary loggings that comes from validating revisions in the offline
migration command. Also cleaned up some codes