Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle undefined data interval in grid runs #23265

Merged
merged 1 commit into from
Apr 26, 2022

Conversation

bbovenzi
Copy link
Contributor

@bbovenzi bbovenzi commented Apr 26, 2022

Continuation of #22999

Use dataIntervalStart and a backup of executionDate for dag run tooltips.
Hide data interval text if it is not defined.

Before: (Tooltip and details header are different)
Screen Shot 2022-04-26 at 12 16 54 PM

After: (they are the same)
Screen Shot 2022-04-26 at 12 16 38 PM


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named {pr_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Apr 26, 2022
@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Apr 26, 2022
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@bbovenzi bbovenzi merged commit 1d875a4 into apache:main Apr 26, 2022
@bbovenzi bbovenzi deleted the fix-data-interval-dates branch April 26, 2022 16:45
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) okay to merge It's ok to merge this PR as it does not require more tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants