Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing project_id to the wait_for_job #24020

Merged
merged 1 commit into from
May 30, 2022
Merged

Added missing project_id to the wait_for_job #24020

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions airflow/providers/apache/beam/operators/beam.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,6 +319,7 @@ def execute(self, context: 'Context'):
location=self.dataflow_config.location,
job_id=self.dataflow_job_id,
multiple_jobs=False,
project_id=self.dataflow_config.project_id,
)
return {"dataflow_job_id": self.dataflow_job_id}
else:
Expand Down Expand Up @@ -600,6 +601,7 @@ def execute(self, context: 'Context'):
location=self.dataflow_config.location,
job_id=self.dataflow_job_id,
multiple_jobs=False,
project_id=self.dataflow_config.project_id,
)
return {"dataflow_job_id": self.dataflow_job_id}
else:
Expand Down
2 changes: 2 additions & 0 deletions tests/providers/apache/beam/operators/test_beam.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@ def test_exec_dataflow_runner(self, gcs_hook, dataflow_hook_mock, beam_hook_mock
job_name=job_name,
location='us-central1',
multiple_jobs=False,
project_id=dataflow_config.project_id,
)
dataflow_hook_mock.return_value.provide_authorized_gcloud.assert_called_once_with()

Expand Down Expand Up @@ -415,6 +416,7 @@ def test_exec_dataflow_runner(self, gcs_hook, dataflow_hook_mock, beam_hook_mock
job_name=job_name,
location='us-central1',
multiple_jobs=False,
project_id=dataflow_config.project_id,
)
dataflow_hook_mock.return_value.provide_authorized_gcloud.assert_called_once_with()

Expand Down