Don't crash scheduler if exec config has old k8s objects #24117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
provider:cncf-kubernetes
2 tasks
dstandish
force-pushed
the
fix-incompat-executor-config
branch
from
67a0860
to
ece6e96
Compare
dstandish
changed the title
dstandish
changed the title
dstandish
changed the title
From time to time k8s library objects change their attrs. If executor config is stored with old version, and unpickled with new version, we can get attribute errors that can crash the scheduler (see apache#23727). Here we update handling so that we fail the task but don't crash the scheduler.
dstandish
force-pushed
the
fix-incompat-executor-config
branch
from
ece6e96
to
8594b96
Compare
jedcunningham
approved these changes
Jun 14, 2022
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
potiuk
approved these changes
Jun 14, 2022
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jun 15, 2022
…che#24117)" This reverts commit 0c41f43.
ephraimbuddy
pushed a commit
to astronomer/airflow
that referenced
this pull request
Jun 16, 2022
From time to time k8s library objects change their attrs. If executor config is stored with old version, and unpickled with new version, we can get attribute errors that can crash the scheduler (see apache#23727). Here we update handling so that we fail the task but don't crash the scheduler. (cherry picked from commit 0c41f43)
ephraimbuddy
pushed a commit
that referenced
this pull request
Jun 30, 2022
From time to time k8s library objects change their attrs. If executor config is stored with old version, and unpickled with new version, we can get attribute errors that can crash the scheduler (see #23727). Here we update handling so that we fail the task but don't crash the scheduler. (cherry picked from commit 0c41f43)
This was referenced Jul 2, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From time to time k8s library objects change their attrs. If executor config is stored with old version, and unpickled with new version, we can get attribute errors that can crash the scheduler (see #23727).
Here we update handling so that we fail the task but don't crash the scheduler.
resolves #23727