Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIP-47 - Migrate google leveldb DAGs to new design ##22447 #24233

Merged
merged 1 commit into from
Jun 7, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ Put key
Get, put, delete key or write_batch, create database with comparator or different options in LevelDB is performed with the
:class:`~airflow.providers.google.leveldb.operators.leveldb.LevelDBOperator` operator.

.. exampleinclude:: /../../airflow/providers/google/leveldb/example_dags/example_leveldb.py
.. exampleinclude:: /../../tests/system/providers/google/leveldb/example_leveldb.py
:language: python
:dedent: 4
:start-after: [START howto_operator_leveldb_put_key]
Expand Down
17 changes: 17 additions & 0 deletions tests/system/providers/google/leveldb/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
#
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,18 @@
Example use of LevelDB operators.
"""

import os
from datetime import datetime

from airflow import models
from airflow.providers.google.leveldb.operators.leveldb import LevelDBOperator
from airflow.utils.trigger_rule import TriggerRule

ENV_ID = os.environ.get("SYSTEM_TESTS_ENV_ID")
DAG_ID = "example_leveldb"

with models.DAG(
'example_leveldb',
DAG_ID,
start_date=datetime(2021, 1, 1),
schedule_interval='@once',
catchup=False,
Expand All @@ -40,6 +45,19 @@
command='put',
key=b'another_key',
value=b'another_value',
trigger_rule=TriggerRule.ALL_DONE,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What this operator is doing, do we need a trigger rule ALL_DONE here? It's usually used when we want to ensure that operator always runs (for example if operator removes some resource at the end of test)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, Updated the PR

)
# [END howto_operator_leveldb_put_key]
get_key_leveldb_task >> put_key_leveldb_task

from tests.system.utils.watcher import watcher

# This test needs watcher in order to properly mark success/failure
# when "tearDown" task with trigger rule is part of the DAG
list(dag.tasks) >> watcher()


from tests.system.utils import get_test_run # noqa: E402

# Needed to run the example DAG with pytest (see: tests/system/README.md#run_via_pytest)
test_run = get_test_run(dag)