Return empty dict if Pod JSON encoding fails #24478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
potiuk
reviewed
Jun 15, 2022
When UI unpickles executor_configs with outdated k8s objects it can run into the same issue as the scheduler does (see apache#23727). Our JSON encoder therefore needs to suppress encoding errors arising from pod serialization, and fallback to a default value.
dstandish
force-pushed
the
fix-webserver-crash-k8s-stale
branch
from
4cd1321
to
b106bf7
Compare
potiuk
approved these changes
Jun 15, 2022
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
ephraimbuddy
pushed a commit
that referenced
this pull request
Jun 29, 2022
When UI unpickles executor_configs with outdated k8s objects it can run into the same issue as the scheduler does (see #23727). Our JSON encoder therefore needs to suppress encoding errors arising from pod serialization, and fallback to a default value.
This was referenced Jul 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When UI unpickles executor_configs with outdated k8s objects it can run into the same issue as the scheduler does (see #23727).
Our JSON encoder therefore needs to suppress encoding errors arising from pod serialization, and fallback to a default value.