Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to webpack 5 #24485

Merged
merged 5 commits into from
Jun 16, 2022
Merged

Upgrade to webpack 5 #24485

merged 5 commits into from
Jun 16, 2022

Conversation

bbovenzi
Copy link
Contributor

@bbovenzi bbovenzi commented Jun 15, 2022

Upgrade to webpack 5. This also helps to fix a lot of peer dependency issues we had and fix vulnerabilities without tacking on resolutions to package.json

Note: One of the linters was updated with new rules hence a number of javascript changes.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named {pr_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:dev-tools area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Jun 15, 2022
@bbovenzi bbovenzi changed the title Update package.json to update to webpack5 Update package.json as a prereq for webpack5 Jun 15, 2022
@bbovenzi bbovenzi changed the title Update package.json as a prereq for webpack5 Upgrade to webpack 5 Jun 16, 2022
@bbovenzi bbovenzi marked this pull request as ready for review June 16, 2022 16:27
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know about some of the changes needed but upgrading deps like that is super cooll

@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Jun 16, 2022
@bbovenzi bbovenzi merged commit 127f8f4 into apache:main Jun 16, 2022
@bbovenzi bbovenzi deleted the update-webpack branch June 16, 2022 18:35
@bbovenzi bbovenzi added this to the Airflow 2.3.3 milestone Jun 28, 2022
ephraimbuddy pushed a commit that referenced this pull request Jun 30, 2022
* update webpack-cli, eslint, stylelint, babel

* revert stylelint changes

* update more plugins

* update to webpack 5

* remove all resolutions

(cherry picked from commit 127f8f4)
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Jun 30, 2022
@ephraimbuddy ephraimbuddy added type:misc/internal Changelog: Misc changes that should appear in change log and removed changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) labels Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-tools area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues okay to merge It's ok to merge this PR as it does not require more tests type:misc/internal Changelog: Misc changes that should appear in change log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants