Update flask-appbuilder authlib/oauth dependency #24516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dependency we have for flask-appbuilder oauth authentication (for github/google authentication) should follow the limits that flask-appbuilder current version has. We added authlib there but apparently FAB currently limits authlib to <= 1.0 - we should follow fab rather than have our own dependency here. This has been pointed out in dpgaspar/Flask-AppBuilder#1861
potiuk
requested review from
jedcunningham,
dstandish,
ephraimbuddy,
eladkal,
ashb and
kaxil
|
I am also going to update authlib to 1.0.0 (from 1.0.1) in our constraints and released images (I will use the new way of generating images :). so that users are unaffected - apparently 1.0.1 breaks authentication flow of FAB Constraints rock. |
potiuk
added a commit
that referenced
this pull request
Jun 17, 2022
potiuk
added a commit
that referenced
this pull request
Jun 17, 2022
potiuk
added a commit
that referenced
this pull request
Jun 17, 2022
1 task
|
This one will also be needed when we merge #24399, so that we keep authlib synced with FAB. |
eladkal
approved these changes
Jun 19, 2022
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
Merged
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jun 22, 2022
Added note about reganerating images in June 2022. The noteis about image changes after refreshing are now better organized (around date of the change) - this should be more useful by the users who will look why their images have been refreshed. Related to: apache#24516
potiuk
added a commit
that referenced
this pull request
Jun 23, 2022
The note is about image changes after refreshing are now better organized (around date of the change) - this should be more useful by the users who will look why their images have been refreshed. Related to: #24516
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jun 29, 2022
The dependency we have for flask-appbuilder oauth authentication (for github/google authentication) should follow the limits that flask-appbuilder current version has. We added authlib there but apparently FAB currently limits authlib to <= 1.0 - we should follow fab rather than have our own dependency here. This has been pointed out in dpgaspar/Flask-AppBuilder#1861 (cherry picked from commit 5674491)
ephraimbuddy
added
the
type:misc/internal
This was referenced Jul 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dependency we have for flask-appbuilder oauth authentication
(for github/google authentication) should follow the limits
that flask-appbuilder current version has. We added authlib there
but apparently FAB currently limits authlib to <= 1.0 - we should
follow fab rather than have our own dependency here.
This has been pointed out in
dpgaspar/Flask-AppBuilder#1861
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named
{pr_number}.significant.rst, in newsfragments.