Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch sql_alchemy_conn if old Postgres schemes used #24569

Merged
merged 3 commits into from
Jun 22, 2022
Merged

Patch sql_alchemy_conn if old Postgres schemes used #24569

merged 3 commits into from
Jun 22, 2022

Conversation

slyapustin
Copy link
Contributor

@slyapustin slyapustin commented Jun 20, 2022

This PR fixed the unsupported postgres:// schema since SQLAlchemy 1.4.

It's an enhanced version of #22333.

It's specifically fixed an issue with Heroku default Postgres URI:
https://help.heroku.com/ZKNTJQSK/why-is-sqlalchemy-1-4-x-not-connecting-to-heroku-postgres

This is a blocker for the Airflow Heroku integration at that moment:
https://github.com/slyapustin/airflow-on-heroku

@boring-cyborg
Copy link

boring-cyborg bot commented Jun 20, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@potiuk
Copy link
Member

potiuk commented Jun 21, 2022

nice!

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Jun 21, 2022
@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@slyapustin
Copy link
Contributor Author

Thanks for approving PR @potiuk
I just updated it to fix the flake8 issue (long line in the docstring).

@potiuk potiuk merged commit 0527a0b into apache:main Jun 22, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Jun 22, 2022

Awesome work, congrats on your first merged pull request!

@potiuk
Copy link
Member

potiuk commented Jun 22, 2022

Some timeout issues. (we need to fix them soon BTW).

@kaxil kaxil added this to the Airflow 2.3.3 milestone Jun 22, 2022
@kaxil
Copy link
Member

kaxil commented Jun 22, 2022

cc @ephraimbuddy @jedcunningham -- We should include this in 2.3.3

@jedcunningham jedcunningham added the type:bug-fix Changelog: Bug Fixes label Jun 22, 2022
@slyapustin slyapustin deleted the warn-patch-sqlalchemy-postgres-schemes-change branch June 23, 2022 08:13
ephraimbuddy pushed a commit that referenced this pull request Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full tests needed We need to run full set of tests for this PR to merge type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants