Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix migration 0080_2_0_2 - Replace null values before setting column not null #24585

Merged
merged 2 commits into from
Jun 29, 2022

Conversation

tm-drtina
Copy link
Contributor

Partially reverts change from #20962 where update to NULL values was dropped.
Default only applies to INSERTs and UPDATEs or newly added columns (at least in postgres), so if the column contained NULLs before, the migration fails.

closes: #24566


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named {pr_number}.significant.rst, in newsfragments.

@boring-cyborg
Copy link

boring-cyborg bot commented Jun 21, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Jun 22, 2022
@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@tm-drtina tm-drtina force-pushed the fix-migration-0080_2_0_2 branch 2 times, most recently from b4c8508 to 1a2c798 Compare June 22, 2022 12:09
@tm-drtina
Copy link
Contributor Author

Maybe I misunderstood the message, but I though I had to rebase the PR. Anyway the pull of python image failed due to unauthenticated access.

error pulling image configuration: unauthorized: unauthenticated: User cannot be authenticated with the token provided.
There was an error pulling the image 3.7. Failing.
There was an error when pulling CI image: Image Python 3.7

@uranusjr
Copy link
Member

It’s not you, GitHub was having issues.

@potiuk
Copy link
Member

potiuk commented Jun 23, 2022

I re-run to rebuild because we updated big set of dependency changes yesterday (FAB 4.1.1) and second build failed due to constraints there.

@eladkal eladkal added this to the Airflow 2.3.3 milestone Jun 28, 2022
@uranusjr uranusjr merged commit 9f58e82 into apache:main Jun 29, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Jun 29, 2022

Awesome work, congrats on your first merged pull request!

@tm-drtina tm-drtina deleted the fix-migration-0080_2_0_2 branch June 29, 2022 07:35
ephraimbuddy pushed a commit that referenced this pull request Jun 29, 2022
@ephraimbuddy ephraimbuddy added the type:bug-fix Changelog: Bug Fixes label Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full tests needed We need to run full set of tests for this PR to merge type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration changes column to NOT NULL without updating NULL data first
6 participants