-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix migration 0080_2_0_2 - Replace null values before setting column not null #24585
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
airflow/migrations/versions/0080_2_0_2_change_default_pool_slots_to_1.py
Outdated
Show resolved
Hide resolved
295a268
to
f7091f7
Compare
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
b4c8508
to
1a2c798
Compare
Maybe I misunderstood the message, but I though I had to rebase the PR. Anyway the pull of python image failed due to unauthenticated access.
|
It’s not you, GitHub was having issues. |
1a2c798
to
54a6e13
Compare
I re-run to rebuild because we updated big set of dependency changes yesterday (FAB 4.1.1) and second build failed due to constraints there. |
54a6e13
to
fa056ae
Compare
Awesome work, congrats on your first merged pull request! |
Partially reverts change from #20962 where update to NULL values was dropped.
Default only applies to INSERTs and UPDATEs or newly added columns (at least in postgres), so if the column contained NULLs before, the migration fails.
closes: #24566
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named
{pr_number}.significant.rst
, in newsfragments.