-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move fallible ti.task.dag assignment back inside try/except block (#24533) #24592
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
It looks like ti.task.dag was originally protected inside try/except, but was moved out at commit 7be87d
85803b1
to
8d68822
Compare
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
81c6b3d
to
6eb5286
Compare
Another good catch. Thanks for the review and commit, I appreciate the detail. What's the process to get this into main branch from here? Is anything else needed? (first time PR for me) |
We generally need two committer reviews to merge a PR, so let’s wait for now. |
Awesome work, congrats on your first merged pull request! |
…4533) (#24592) * Move fallible ti.task.dag assignment back inside try/except block It looks like ti.task.dag was originally protected inside try/except, but was moved out at commit 7be87d * Remove unneeded variable annotation Co-authored-by: EJ Kreinar <ej@he360.com> Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> (cherry picked from commit 97948ec)
…4533) (#24592) * Move fallible ti.task.dag assignment back inside try/except block It looks like ti.task.dag was originally protected inside try/except, but was moved out at commit 7be87d * Remove unneeded variable annotation Co-authored-by: EJ Kreinar <ej@he360.com> Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> (cherry picked from commit 97948ec)
It looks like ti.task.dag was originally protected inside try/except, but was moved out at commit 7be87d
This causes the "View Logs in Elasticsearch" option to crash in the Airflow UI
related: #24533