Fix cycle bug with attaching label to task group #24847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem was specific to EdgeModifiers as they try to be "transparent" to upstream/downstream The fix is to set track the upstream/downstream for the task group before making any changes to the EdgeModifiers' relations -- otherwise the roots of the TG were added as dependencies to themeslves!
jedcunningham
approved these changes
Jul 5, 2022
ephraimbuddy
approved these changes
Jul 5, 2022
|
Did we have DCG instad of DAG for a short while :) ? |
potiuk
approved these changes
Jul 5, 2022
|
Only in this one specific edge case where you do |
ephraimbuddy
pushed a commit
that referenced
this pull request
Jul 5, 2022
The problem was specific to EdgeModifiers as they try to be "transparent" to upstream/downstream The fix is to set track the upstream/downstream for the task group before making any changes to the EdgeModifiers' relations -- otherwise the roots of the TG were added as dependencies to themeslves! (cherry picked from commit efc05a5)
74 tasks
|
Verified |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was specific to EdgeModifiers as they try to be
"transparent" to upstream/downstream
The fix is to set track the upstream/downstream for the task group
before making any changes to the EdgeModifiers' relations -- otherwise
the roots of the TG were added as dependencies to themeslves!
Fixes #19785