Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve grid date tick spacing #24849

Merged
merged 1 commit into from
Jul 5, 2022

Conversation

bbovenzi
Copy link
Contributor

@bbovenzi bbovenzi commented Jul 5, 2022

There was an issue of date tick spacing when there were 11-13 dag runs. This PR fixes that by counting shouldShowTick with the inverse of the run index and counting backwards.

Before:
Screen Shot 2022-07-05 at 1 24 50 PM

After:
Screen Shot 2022-07-05 at 1 25 24 PM


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Jul 5, 2022
@bbovenzi bbovenzi added this to the Airflow 2.3.3 milestone Jul 5, 2022
@ephraimbuddy ephraimbuddy merged commit 6caaf47 into apache:main Jul 5, 2022
@ephraimbuddy ephraimbuddy deleted the improve-grid-ticks branch July 5, 2022 18:01
@ephraimbuddy ephraimbuddy added the kind:bug This is a clearly a bug label Jul 5, 2022
ephraimbuddy pushed a commit that referenced this pull request Jul 5, 2022
@ephraimbuddy ephraimbuddy added the type:bug-fix Changelog: Bug Fixes label Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues kind:bug This is a clearly a bug type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants