-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allowing task_group Sensor in ExternalTaskSensor #24902
Conversation
cases
|
1425c95
to
eb29793
Compare
Hi @eladkal, could you please take a look into this PR. |
Since we are already allowing multiple task IDs, I wonder if we should just go directly with |
@uranusjr, we already allow multiple taskIds which I personally don't think a good idea, because it is not very transparent. Although For TaskGroup, I think if someone want to depend on multiple of them, they must create different task sensors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
closes: #14563
related: #14640
Add meaningful description above
Hi All,
This PR proposes to allow users to provide external_task_group_id in ExternalTaskSensor to make tasks on a DAG wait for another task_group on a different DAG for a specific execution_date.
we can also provide options to set if the Task on a remote DAG succeeded or failed via allowed_states and failed_states parameters.